fix: Do not compute Brier score when predict_proba is not available #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustebaum
changed the title
augustebaum
suggested changes
Jan 9, 2025
Contributor
|
Nice work, just a suggestion for the |
waridrox
pushed a commit
to waridrox/skore
that referenced
this pull request
Apr 15, 2025
…robabl-ai#1064) closes probabl-ai#1050 As specified, do not try to compute Brier score with an estimator that does not provide probability estimate (i.e. does not have a `predict_proba` method). Added a non-regression test as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1050
As specified, do not try to compute Brier score with an estimator that does not provide probability estimate (i.e. does not have a
predict_probamethod).Added a non-regression test as well.